diff --git a/src/memberdb/register.py b/src/memberdb/register.py index 06a78b2b638371b8ebc66ea5f7829a366364246b..68e3d343ce3e0b40576b37e9f2d9d2ebc3380155 100644 --- a/src/memberdb/register.py +++ b/src/memberdb/register.py @@ -181,7 +181,7 @@ class RenewView(LoginRequiredMixin, RegisterView): def form_valid(self, form): m, ms = form.save() messages.success(self.request, 'Your membership renewal has been submitted.') - if self.request.user.is_staff: - return HttpResponseRedirect(reverse("admin:membership-approve",args=[ms.pk])) - else: - return HttpResponseRedirect(reverse("memberdb:home")) + + # always redirect to member home on renewal - you can't renew for someone else, and it + # is confusing if you get redirected to the admin site + return HttpResponseRedirect(reverse("memberdb:home"))