From 906b7ca8c05bb401716363a46c5e3c3a280ce763 Mon Sep 17 00:00:00 2001 From: frekk Date: Tue, 26 Feb 2019 20:52:02 +0800 Subject: [PATCH] don't redirect to admin site from renewal form --- src/memberdb/register.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/memberdb/register.py b/src/memberdb/register.py index 06a78b2..68e3d34 100644 --- a/src/memberdb/register.py +++ b/src/memberdb/register.py @@ -181,7 +181,7 @@ class RenewView(LoginRequiredMixin, RegisterView): def form_valid(self, form): m, ms = form.save() messages.success(self.request, 'Your membership renewal has been submitted.') - if self.request.user.is_staff: - return HttpResponseRedirect(reverse("admin:membership-approve",args=[ms.pk])) - else: - return HttpResponseRedirect(reverse("memberdb:home")) + + # always redirect to member home on renewal - you can't renew for someone else, and it + # is confusing if you get redirected to the admin site + return HttpResponseRedirect(reverse("memberdb:home")) -- GitLab