diff --git a/cli-main.c b/cli-main.c index 3db8f2ff4d0ece3ff8ae01f8ef3538aadb9a7081..8c7f2ef77551446c4421adae748284c03998172c 100644 --- a/cli-main.c +++ b/cli-main.c @@ -107,9 +107,10 @@ static void cli_dropbear_exit(int exitcode, const char* format, va_list param) { /* Do the cleanup first, since then the terminal will be reset */ session_cleanup(); + /* Avoid printing onwards from terminal cruft */ + fprintf(stderr, "\n"); _dropbear_log(LOG_INFO, fmtbuf, param); - exit(exitcode); } @@ -121,7 +122,7 @@ static void cli_dropbear_log(int UNUSED(priority), vsnprintf(printbuf, sizeof(printbuf), format, param); fprintf(stderr, "%s: %s\n", cli_opts.progname, printbuf); - + fflush(stderr); } static void exec_proxy_cmd(void *user_data_cmd) { diff --git a/common-channel.c b/common-channel.c index 634d823875b56664bdd2e23f799abc83bba94558..61b112065e0d83422e77566ac63b719ce5442323 100644 --- a/common-channel.c +++ b/common-channel.c @@ -574,14 +574,16 @@ static void remove_channel(struct Channel * channel) { } - /* close the FDs in case they haven't been done - * yet (they might have been shutdown etc) */ - TRACE(("CLOSE writefd %d", channel->writefd)) - close(channel->writefd); - TRACE(("CLOSE readfd %d", channel->readfd)) - close(channel->readfd); - TRACE(("CLOSE errfd %d", channel->errfd)) - close(channel->errfd); + if (IS_DROPBEAR_SERVER || (channel->writefd != STDOUT_FILENO)) { + /* close the FDs in case they haven't been done + * yet (they might have been shutdown etc) */ + TRACE(("CLOSE writefd %d", channel->writefd)) + close(channel->writefd); + TRACE(("CLOSE readfd %d", channel->readfd)) + close(channel->readfd); + TRACE(("CLOSE errfd %d", channel->errfd)) + close(channel->errfd); + } if (!channel->close_handler_done && channel->type->closehandler) {