From 9e66b5a9b1db60ca298eb76de413f2ecbeae2556 Mon Sep 17 00:00:00 2001
From: Matt Johnston <matt@ucc.asn.au>
Date: Sun, 1 Mar 2015 23:26:42 +0800
Subject: [PATCH] reword comment for clarity
--HG--
branch : nocircbuffer
---
common-session.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/common-session.c b/common-session.c
index be8f776a..164dc858 100644
--- a/common-session.c
+++ b/common-session.c
@@ -152,8 +152,10 @@ void session_loop(void(*loophandler)()) {
FD_ZERO(&readfd);
dropbear_assert(ses.payload == NULL);
- /* during initial setup we flush out the KEXINIT packet before
- * attempting to read the remote version string, which might block */
+ /* We delay reading from the input socket during initial setup until
+ after we have written out our initial KEXINIT packet (empty writequeue).
+ This means our initial packet can be in-flight while we're doing a blocking
+ read for the remote ident */
if (ses.sock_in != -1 && (ses.remoteident || isempty(&ses.writequeue))) {
FD_SET(ses.sock_in, &readfd);
}
--
GitLab