From aa30ce2dffcfd4975ebf3fa1b138ab247ae87872 Mon Sep 17 00:00:00 2001 From: Matt Johnston <matt@ucc.asn.au> Date: Sun, 14 May 2023 23:01:55 +0800 Subject: [PATCH] Disable signature reverification for now It's slow on the rp2040. Instead we should add entropy inside the ed25519 signature generation. --- src/sign.rs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/src/sign.rs b/src/sign.rs index ef00bb0..fcf53ec 100644 --- a/src/sign.rs +++ b/src/sign.rs @@ -308,14 +308,14 @@ impl SignKey { }; - { - // Faults in signing can expose the private key. We verify the signature - // just created to avoid this problem. - // TODO: Maybe this needs to be configurable for slow platforms? - let vsig: Signature = (&sig).into(); - let sig_type = vsig.sig_type().unwrap(); - sig_type.verify(&self.pubkey(), msg, &vsig, parse_ctx)?; - } + // { + // // Faults in signing can expose the private key. We verify the signature + // // just created to avoid this problem. + // // TODO: Maybe this needs to be configurable for slow platforms? + // let vsig: Signature = (&sig).into(); + // let sig_type = vsig.sig_type().unwrap(); + // sig_type.verify(&self.pubkey(), msg, &vsig, parse_ctx)?; + // } Ok(sig) } -- GitLab