Skip to content
Snippets Groups Projects
Commit 2af1d1b5 authored by Roy Xu's avatar Roy Xu
Browse files

Return RV_SUCCESS when door confimation is not Y/y, hopefully this will stop SIGSEGV poping out

parent 40bc20a2
Pipeline #763 passed with stages
in 2 minutes and 59 seconds
  • Contributor

    It crashes because the i variable isn't initialised properly at the top of the function (line 596), so it gets any old value left in it, 1288 in my test. When control falls through this if block, it ends up passing through to line 828 ("check for a valid item ID"). All the other else blocks that fall through to this line set an item ID, so 836 tries to look up item ID 1288 which is well past the end of the array.

  • David Adam @zanchey

    mentioned in merge request !5

    ·

    mentioned in merge request !5

    Toggle commit list
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment