- May 04, 2016
-
-
Matt Johnston authored
-
- May 03, 2016
-
-
Matt Johnston authored
-
- Jul 12, 2016
-
-
Matt Johnston authored
-
Matt Johnston authored
-
Matt Johnston authored
toint() from misc.c (revids are from hggit conversion) changeset: 4620:60a336a6c85c user: Simon Tatham <anakin@pobox.com> date: Thu Feb 25 20:26:33 2016 +0000 files: import.c description: Fix potential segfaults in reading OpenSSH's ASN.1 key format. The length coming back from ber_read_id_len might have overflowed, so treat it as potentially negative. Also, while I'm here, accumulate it inside ber_read_id_len as an unsigned, so as to avoid undefined behaviour on integer overflow, and toint() it before return. Thanks to Hanno Böck for spotting this, with the aid of AFL. (cherry picked from commit 5b7833cd474a24ec098654dcba8cb9509f3bf2c1) Conflicts: import.c (cherry-picker's note: resolving the conflict involved removing an entire section of the original commit which fixed ECDSA code not present on this branch) changeset: 4619:9c6c638d98d8 user: Simon Tatham <anakin@pobox.com> date: Sun Jul 14 10:45:54 2013 +0000 files: import.c ssh.c sshdss.c sshpubk.c sshrsa.c description: Tighten up a lot of casts from unsigned to int which are read by one of the GET_32BIT macros and then used as length fields. Missing bounds checks against zero have been added, and also I've introduced a helper function toint() which casts from unsigned to int in such a way as to avoid C undefined behaviour, since I'm not sure I trust compilers any more to do the obviously sensible thing. [originally from svn r9918] changeset: 4618:3957829f24d3 user: Simon Tatham <anakin@pobox.com> date: Mon Jul 08 22:36:04 2013 +0000 files: import.c sshdss.c sshrsa.c description: Add an assortment of extra safety checks. [originally from svn r9896] changeset: 4617:2cddee0bce12 user: Jacob Nevins <jacobn@chiark.greenend.org.uk> date: Wed Dec 07 00:24:45 2005 +0000 files: import.c description: Institutional failure to memset() things pointed at rather than pointers. Things should now be zeroed and memory not leaked. Spotted by Brant Thomsen. [originally from svn r6476] changeset: 4616:24ac78a9c71d user: Simon Tatham <anakin@pobox.com> date: Wed Feb 11 13:58:27 2004 +0000 files: import.c description: Jacob's last-minute testing found a couple of trivial bugs in import.c, and my attempts to reproduce them in cmdgen found another one there :-) [originally from svn r3847] changeset: 4615:088d39a73db0 user: Simon Tatham <anakin@pobox.com> date: Thu Jan 22 18:52:49 2004 +0000 files: import.c description: Placate some gcc warnings. [originally from svn r3761] changeset: 4614:e4288bad4d93 parent: 1758:108b8924593d user: Simon Tatham <anakin@pobox.com> date: Fri Oct 03 21:21:23 2003 +0000 files: import.c description: My ASN.1 decoder returned wrong IDs for anything above 0x1E! Good job it's never had to yet. Ahem. [originally from svn r3479]
-
- Jan 01, 2016
-
-
Francois Perrad authored
-
- Jun 04, 2015
-
-
Matt Johnston authored
-
- May 06, 2015
-
-
Gaël PORTAY authored
-
Gaël PORTAY authored
-
Gaël PORTAY authored
buf_incrwritepos() and mp_to_unsigned_bin() functions use k_size as signed integer argument. k_size is also used in an assertion that compared it to curve_size which is a signed long. Only buf_getwriteptr() is using k_size as unsigned. So it safe to use it as signed.
-
- Feb 24, 2015
-
-
Thorsten Horstmann authored
-
Thorsten Horstmann authored
and /**/ comments
-
- Jan 28, 2015
-
-
Christian Engelmayer authored
of the pointer to the data instead of the whole size of struct openssh_key is cleared. Correct the size calculation as detected by Coverity CID 1191543.
-
- Jan 23, 2015
-
-
Like Ma authored
(fixup of pull request #7)
-
- Jun 25, 2014
-
-
Matt Johnston authored
-
- Nov 27, 2013
-
-
Matt Johnston authored
- Fix assertion that key size is exactly curve size
-
- Nov 14, 2013
-
-
Matt Johnston authored
-
- Nov 08, 2013
-
-
Matt Johnston authored
--HG-- branch : ecc
-
- Nov 07, 2013
-
-
Matt Johnston authored
--HG-- branch : keyondemand
-
Matt Johnston authored
Needs UI in server command line options --HG-- branch : keyondemand
-
- Nov 01, 2013
-
-
Matt Johnston authored
--HG-- branch : ecc
-
- Oct 20, 2013
-
-
Matt Johnston authored
--HG-- branch : ecc
-
- May 25, 2013
-
-
Matt Johnston authored
fix crash from the mp_alloc_init_multi change in RSA --HG-- branch : ecc
-
- May 23, 2013
-
-
Matt Johnston authored
--HG-- branch : ecc
-
- Apr 14, 2013
-
-
Matt Johnston authored
--HG-- branch : ecc
-
- Sep 22, 2008
-
-
Matt Johnston authored
--HG-- extra : convert_revision : 63f95bd7b4b15b61cd13cdcc86cdeef2681ce6e7
-
- Jul 07, 2006
-
-
Matt Johnston authored
cli-authpubkey.c: fix leak of keybuf cli-kex.c: fix leak of fingerprint fp cli-service.c: remove commented out code dropbearkey.c: don't attepmt to free NULL key on failure common-kex.c: only free key if it is initialised keyimport.c: remove dead encrypted-key code don't leak a FILE* loading OpenSSH keys rsa.c, dss.c: check return values for some libtommath functions svr-kex.c: check return value retrieving DH kex mpint svr-tcpfwd.c: fix null-dereference if remote tcp forward request fails tcp-accept.c: don't incorrectly free the tcpinfo var --HG-- extra : convert_revision : 640a55bc710cbaa6d212453c750026c770e19193
-
- Nov 30, 2005
-
-
Matt Johnston authored
--HG-- extra : convert_revision : 54840316c94733a793222ad54331ab207b4097e5
-
- Sep 05, 2005
-
-
Matt Johnston authored
--HG-- extra : convert_revision : 3dc365619f0840ab5781660b1257a9f22c05d3fe
-
- Aug 17, 2004
-
-
Matt Johnston authored
--HG-- extra : convert_revision : 83d9a25ee973ab65fa64dcf8595838b160c21663
-
- Aug 15, 2004
-
-
Matt Johnston authored
--HG-- extra : convert_revision : 2d897b12ba8710efe0b042b36b1fd31b2469eb15
-
- Jun 01, 2004
-
-
Matt Johnston authored
--HG-- extra : convert_revision : cc8a8c49dc70e632c352853a39801089b08149be
-